Hotfix/machine id header - #96
Merged
Merged
Conversation
…ame mode Ports the March feature/machine-id-header work onto current main: a cached provider reads the shared OpenFrame machine_id file written by openframe-client, and orbit stamps it on every request alongside the bearer token. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> # Conflicts: # client/orbit_client.go
WalkthroughOpenFrame mode now creates and stores an 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@server/service/openframe/openframe_machine_id_provider.go`:
- Around line 41-42: Update OpenFrameMachineIdProvider.GetMachineId around the
initial read so an empty, non-configured machine ID is not permanently cached:
re-read the file when the cached value is blank, or invoke Refresh at an
appropriate lifecycle point before requests depend on x-machine-id. Preserve
normal caching for valid IDs and configured values.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6d46d40e-830f-4ceb-a76c-21fc82fdb9c3
⛔ Files ignored due to path filters (1)
openframe/docs/agent-openframe-mode.mdis excluded by!**/*.md
📒 Files selected for processing (2)
client/orbit_client.goserver/service/openframe/openframe_machine_id_provider.go
…s retry Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
denys-gif
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes